Add new client for Etherscan API v2 #1407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11614341087Details
💛 - Coveralls |
falvaradorodriguez
force-pushed
the
support-etherscan-v2-api
branch
from
be3120b
to
854637f
Compare
Uxio0
requested changes
Oct 31, 2024
| self.base_api_url = self.BASE_API_V2_URL | ||
|
|
||
| @classmethod | ||
| def _get_supported_networks(cls) -> List[Dict[str, Any]]: |
There was a problem hiding this comment.
I think this should be cached, and also it shouldn't be a private method
There was a problem hiding this comment.
IMO this method will be called rarely times and may even add a new chain along the way. It should have no problems without being cached.
It is updated as public method here
| item.get("chainid") == str(network.value) for item in supported_networks | ||
| ) | ||
|
|
||
| def build_url(self, path: str) -> str: |
There was a problem hiding this comment.
This method should be at the top of the class, just for clarity
There was a problem hiding this comment.
Done here
moisses89
reviewed
Oct 31, 2024
| @@ -320,7 +320,7 @@ def __init__( | |||
| self.request_timeout = request_timeout | |||
|
|
|||
| def build_url(self, path: str): | |||
| url = urljoin(self.base_api_url, path) | |||
| url = urljoin(self.base_api_url, f"api?{path}") | |||
There was a problem hiding this comment.
Maybe the problem is the name of the parameter. I updated it as query here
| ) | ||
|
|
||
| def build_url(self, path: str) -> str: | ||
| url = urljoin(self.base_api_url, f"v2/api?chainid={self.network.value}&{path}") |
There was a problem hiding this comment.
Yes, it's the path. I already updated the name of the parameter.
moisses89
approved these changes
Oct 31, 2024
Uxio0
approved these changes
Nov 4, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More info about the migration: https://docs.etherscan.io/etherscan-v2/getting-started/v2-quickstart